Migrate to AWS SDK V3 - Part 1 #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Jun 8, 2025
lib/configuration/variables/sources/instance-dependent/get-aws.js
Outdated
Show resolved
Hide resolved
GrahamCampbell
force-pushed
the
aws-sdk-v3
branch
from
dc02d82 to
79e9aa0
Compare
mnapoli
reviewed
Jun 12, 2025
| return { value: Account }; | ||
| const provider = serverlessInstance.getProvider('aws'); | ||
| const result = await provider.request('STS', 'getCallerIdentity', {}, { useCache: true }); | ||
| return { value: result.Account }; |
There was a problem hiding this comment.
Can we revert formatting changes like these? This will make the diff much smaller, and also will minimize changes with upstream. It seems like there are 4-5 files impacted.
mnapoli
reviewed
Jun 12, 2025
| ListAttachedRolePoliciesCommand, | ||
| CreateRoleCommand, | ||
| AttachRolePolicyCommand, | ||
| } = require('@aws-sdk/client-iam'); | ||
| const AWSClientFactory = require('../../../../../aws/client-factory'); |
There was a problem hiding this comment.
Aren't these files the custom resource handlers?
If yes, they shouldn't be impacted by the changes in the CLI. And they wouldn't be able to require files from the CLI package (because they would run in Lambda).
There was a problem hiding this comment.
Ah, this was a fix to make sure they are re-using the same client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds AWS SDK v3 support for everything. Opt in to v3 with
SLS_AWS_SDK_V3=1. I am running the CI on both versions in the Node 22 job... however mostly things are mocked, so this is not testing much. A notable difference is that the v2 SDK has memoization that we expose withuseCache. We are not doing that for v3. Do we want that?In a follow-up PR we could flip the default (Part 2), and in another follow-up, remove v2 support (Part 3).
Smashing through this with Claude Code. 🤖