Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper error when parsing telemetry configuration (backport #129… #348

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix: proper error when parsing telemetry configuration (backport #129… #348

merged 1 commit into from
Oct 13, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Oct 12, 2022 •
edited
Loading

Closes: #XXX

What is the purpose of the change

As part of general effort to bring the fork more in sync with upstream, backporting this:
cosmos#12981

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn marked this pull request as ready for review October 12, 2022 05:14
@p0mvn p0mvn requested a review from a team October 12, 2022 05:14
nicolaslara
nicolaslara approved these changes Oct 12, 2022
View reviewed changes
Copy link

@nicolaslara nicolaslara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mattverse
mattverse approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed back port from upstream

@p0mvn p0mvn merged commit 9fed068 into osmosis-main Oct 13, 2022
@p0mvn p0mvn deleted the roman/backport-telemetry branch October 13, 2022 20:08
@mergify mergify bot mentioned this pull request Oct 13, 2022
Merged
mergify bot pushed a commit that referenced this pull request Oct 13, 2022
@p0mvn @mergify
fix: proper error when parsing telemetry configuration (backport cosm…
810e4c8 
…os#12981) (cosmos#12999) (#348)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9fed068)
mattverse pushed a commit that referenced this pull request Oct 13, 2022
@mergify @p0mvn
fix: proper error when parsing telemetry configuration (backport cosm…
fdbdfed 
…os#12981) (cosmos#12999) (#348) (#349)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9fed068)

Co-authored-by: Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaslara nicolaslara nicolaslara approved these changes

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @nicolaslara @mattverse