-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve webhook resilience #3200
Conversation
3baafbc
to
049e96e
Compare
0127cff
to
eeb1898
Compare
Codecov Report
@@ Coverage Diff @@
## master #3200 +/- ##
==========================================
- Coverage 77.95% 77.89% -0.06%
==========================================
Files 320 320
Lines 20428 20451 +23
==========================================
+ Hits 15924 15931 +7
- Misses 3301 3317 +16
Partials 1203 1203
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eeb1898
to
4fa38e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct me, but I don't see new retry logic added, only context timeout added.
I realized that we already had an update of ory/x in a different PR, so the retry logic there is already on master 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
4fa38e2
to
4ed2964
Compare
Changes:
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments