-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use type alias instead of type definition #3148
Conversation
94b7bc4
to
dcbc9be
Compare
dcbc9be
to
c1a9c22
Compare
Codecov Report
@@ Coverage Diff @@
## master #3148 +/- ##
==========================================
- Coverage 77.68% 77.56% -0.13%
==========================================
Files 316 316
Lines 19906 19906
==========================================
- Hits 15464 15440 -24
- Misses 3258 3276 +18
- Partials 1184 1190 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would this be a breaking change in the SDK? I guess since the Go SDK didn't change (apart from the doc comment) no? What does this look like in TS?
I hope not 🙃 |
Related issue(s)
ory/network#251
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments