Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use type alias instead of type definition #3148

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

CaptainStandby
Copy link
Contributor

@CaptainStandby CaptainStandby commented Mar 6, 2023

Related issue(s)

ory/network#251

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CaptainStandby CaptainStandby force-pushed the hf/fix-ListIdentitySchemas branch from 94b7bc4 to dcbc9be Compare March 6, 2023 16:08
@CaptainStandby CaptainStandby marked this pull request as ready for review March 6, 2023 16:08
@CaptainStandby CaptainStandby self-assigned this Mar 6, 2023
@CaptainStandby CaptainStandby force-pushed the hf/fix-ListIdentitySchemas branch from dcbc9be to c1a9c22 Compare March 6, 2023 16:16
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #3148 (5014be6) into master (46eb063) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 5014be6 differs from pull request most recent head c1a9c22. Consider uploading reports for the commit c1a9c22 to get more accurate results

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   77.68%   77.56%   -0.13%     
==========================================
  Files         316      316              
  Lines       19906    19906              
==========================================
- Hits        15464    15440      -24     
- Misses       3258     3276      +18     
- Partials     1184     1190       +6     
Impacted Files Coverage Δ
schema/handler.go 82.27% <ø> (ø)
courier/courier_dispatcher.go 43.42% <0.00%> (-15.79%) ⬇️
persistence/sql/update/update.go 80.00% <0.00%> (-5.72%) ⬇️
persistence/sql/persister_courier.go 83.33% <0.00%> (-4.77%) ⬇️
session/test/persistence.go 99.05% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would this be a breaking change in the SDK? I guess since the Go SDK didn't change (apart from the doc comment) no? What does this look like in TS?

@CaptainStandby
Copy link
Contributor Author

LGTM.

Would this be a breaking change in the SDK? I guess since the Go SDK didn't change (apart from the doc comment) no? What does this look like in TS?

I hope not 🙃

@CaptainStandby CaptainStandby merged commit dba3803 into master Mar 7, 2023
@CaptainStandby CaptainStandby deleted the hf/fix-ListIdentitySchemas branch March 7, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants