Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only return one result set for credentials_identifier #3107

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 15, 2023

Closes #3105

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from jonas-jonas February 15, 2023 22:00
@aeneasr aeneasr requested a review from zepatrik as a code owner February 15, 2023 22:00
@aeneasr
Copy link
Member Author

aeneasr commented Feb 15, 2023

Kinda hacky, but since credentials_identifier has a unique constraint, this is probably acceptable. The pop query builder doesn't support SELECT DISTINCT right now.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #3107 (59c0a40) into master (1193a56) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 59c0a40 differs from pull request most recent head 2659765. Consider uploading reports for the commit 2659765 to get more accurate results

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
- Coverage   77.56%   77.55%   -0.01%     
==========================================
  Files         315      315              
  Lines       19949    19962      +13     
==========================================
+ Hits        15473    15482       +9     
- Misses       3285     3288       +3     
- Partials     1191     1192       +1     
Impacted Files Coverage Δ
identity/test/pool.go 100.00% <100.00%> (ø)
persistence/sql/persister_identity.go 74.74% <100.00%> (+0.12%) ⬆️
session/test/persistence.go 99.05% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, kinda hacky fits :D

But if it works :)

@aeneasr aeneasr merged commit 59f35d1 into master Feb 16, 2023
@aeneasr aeneasr deleted the fix-distinct branch February 16, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listIdentities lists identities multiple times with credential_identifier set
2 participants