Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix wrong message id on resend code button #3067

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Fixes #3051

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

aeneasr
aeneasr previously approved these changes Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #3067 (c31d8fc) into master (dec7cbc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head c31d8fc differs from pull request most recent head e58e727. Consider uploading reports for the commit e58e727 to get more accurate results

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
+ Coverage   77.18%   77.25%   +0.06%     
==========================================
  Files         315      314       -1     
  Lines       19740    19652      -88     
==========================================
- Hits        15237    15182      -55     
+ Misses       3313     3294      -19     
+ Partials     1190     1176      -14     
Impacted Files Coverage Δ
text/message_node.go 100.00% <100.00%> (ø)
selfservice/strategy/oidc/strategy.go 63.31% <0.00%> (ø)
selfservice/strategy/oidc/provider_linkedin.go
selfservice/strategy/oidc/provider_config.go 32.65% <0.00%> (+1.28%) ⬆️
selfservice/strategy/oidc/provider_netid.go 78.26% <0.00%> (+3.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonas-jonas
Copy link
Member Author

Tests fail because of ory/elements#89

@jonas-jonas
Copy link
Member Author

Once ory/kratos-selfservice-ui-node#245 is merged, tests should pass here, and we can merge this.

@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fix/resendCodeMessageId branch from 3455e7b to e58e727 Compare February 9, 2023 10:24
@jonas-jonas jonas-jonas self-assigned this Feb 9, 2023
@jonas-jonas jonas-jonas requested a review from aeneasr February 9, 2023 14:07
@aeneasr aeneasr merged commit e3eb39e into master Feb 13, 2023
@aeneasr aeneasr deleted the jonas-jonas/fix/resendCodeMessageId branch February 13, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI message ID 1070007 is used for multiple messages
2 participants