WDT-639 consistent exit handling across tools #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When singing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. |
ddsharpe
requested review from
robertpatrick,
rakillen,
CarolynRountree and
jshum2479
CarolynRountree
approved these changes
Aug 11, 2022
oracle-contributor-agreement
bot
added
OCA Verified
|
SonarCloud Quality Gate failed. |
robertpatrick
approved these changes
Aug 15, 2022
rakillen
approved these changes
Aug 16, 2022
jshum2479
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to ensure wherever there was a call to logger.entering() that there was a matching logger.exiting(). Also, all tool exits should now be handled consistently, using either _tool_exit.__log_and_exit() to do a logger.exiting() and tool_exit.end() if there was a __logger.entering() or simply tool_exit.end() if not.
Also, removed duplicate code in multiple except blocks, setting an exit code, and after the except blocks, cleaning up temp files and exiting with whatever exit code was set.