-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distribution
prop to SearchSpaceItem
type and move searchSpace
to tslib/react
#892
Conversation
distribution
prop to SearchSpaceItem
type and move searchSpace
to tslib/react
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 69.51% 69.58% +0.06%
==========================================
Files 35 35
Lines 2375 2377 +2
==========================================
+ Hits 1651 1654 +3
+ Misses 724 723 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after passing CI!
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
distribution
prop toSearchSpaceItem
typesearchSpace.ts
fromoptuna_dashboard/ts
totslib/react
vscode/package-lock.json
by Bump braces from 3.0.2 to 3.0.3 in /vscode #890