Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop inf & -inf from TrialValueNumber #808

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

porink0424
Copy link
Collaborator

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Drop inf & -inf from TrialValueNumber

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (88be4cb) to head (b976fa1).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   69.71%   69.53%   -0.18%     
==========================================
  Files          35       35              
  Lines        2364     2367       +3     
==========================================
- Hits         1648     1646       -2     
- Misses        716      721       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabenabe0928 nabenabe0928 self-assigned this Feb 19, 2024
@nabenabe0928
Copy link
Collaborator

nabenabe0928 commented Feb 21, 2024

It seems the following files need the changes:

  • optuna_dashboard/_serializer.py
  • optuna_dashboard/ts/components/GraphContour.tsx
  • optuna_dashboard/ts/components/GraphIntermediateValues.tsx
  • optuna_dashboard/ts/components/GraphParetoFront.tsx
  • optuna_dashboard/ts/components/GraphRank.tsx
  • optuna_dashboard/ts/components/TrialFormWidgets.tsx
  • optuna_dashboard/ts/components/TrialTable.tsx
  • optuna_dashboard/ts/dominatedTrials.ts
  • optuna_dashboard/ts/trialFilter.ts
  • optuna_dashboard/ts/types/index.d.ts
  • standalone_app/src/components/PlotHistory.tsx
  • standalone_app/src/components/PlotImportance.tsx
  • standalone_app/src/components/PlotIntermediateValues.tsx
  • standalone_app/src/components/TrialTable.tsx
  • standalone_app/src/sqlite3.ts
  • standalone_app/src/types/index.d.ts

@c-bata
Copy link
Member

c-bata commented Feb 21, 2024

@nabenabe0928 Thank you for your review! The codebases for the standalone app (which is internally used from the VS Code extension) are separated with the codebases for the Python package. So could you only check the files under the standalone_app directory?

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change, LGTM")

@nabenabe0928 nabenabe0928 removed their assignment Feb 29, 2024
@c-bata c-bata merged commit 52d64f0 into optuna:main Feb 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants