-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop inf & -inf from TrialValueNumber #808
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
==========================================
- Coverage 69.71% 69.53% -0.18%
==========================================
Files 35 35
Lines 2364 2367 +3
==========================================
- Hits 1648 1646 -2
- Misses 716 721 +5 ☔ View full report in Codecov by Sentry. |
It seems the following files need the changes:
|
@nabenabe0928 Thank you for your review! The codebases for the standalone app (which is internally used from the VS Code extension) are separated with the codebases for the Python package. So could you only check the files under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change, LGTM")
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Drop inf & -inf from TrialValueNumber