Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test with optuna master #793

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

keisuke-umezawa
Copy link
Member

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

optuna/optuna#5211

What does this implement/fix? Explain your changes.

optuna/optuna#5211 broke the unittest, and this PR will fix it.

@c-bata
Copy link
Member

c-bata commented Feb 6, 2024

Just FYI, we temporarily disabled e2e tests on #795. Please revert that change after fixing the problem 🙇

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8c48e7e) 69.13% compared to head (522b6ff) 68.96%.
Report is 12 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   69.13%   68.96%   -0.17%     
==========================================
  Files          35       35              
  Lines        2378     2388      +10     
==========================================
+ Hits         1644     1647       +3     
- Misses        734      741       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit 83b548f into optuna:main Feb 6, 2024
15 checks passed
@keisuke-umezawa keisuke-umezawa deleted the fix/optuna-main-test branch February 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants