Delete code for optuna v2 #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
+ Coverage 68.96% 69.81% +0.84%
==========================================
Files 35 35
Lines 2388 2369 -19
==========================================
+ Hits 1647 1654 +7
+ Misses 741 715 -26 ☔ View full report in Codecov by Sentry. |
keisuke-umezawa
changed the title
c-bata
requested changes
Feb 9, 2024
standalone_app/src/sqlite3.ts
Outdated
| @@ -287,30 +287,6 @@ const parseDistributionJSON = (t: string): Distribution => { | |||
| step: parsed.attributes.step as number, | |||
| log: parsed.attributes.log as boolean, | |||
| } | |||
| } else if (parsed.name === "UniformDistribution") { | |||
There was a problem hiding this comment.
The standalone app does not depend on Optuna directly, so that it seems not relevant with the dropping support for Optuna v2. Could you keep these existing code?
There was a problem hiding this comment.
oh, sorry, I understand. I will fix it.
keisuke-umezawa
force-pushed
the
fix/delete-code-v2
branch
from
2dd6c0d to
d30ed93
Compare
c-bata
approved these changes
Feb 9, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.