Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning messages #769

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Jan 24, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Before

$ optuna-dashboard sqlite:///db.sqlite3 --host 0.0.0.0
[2024-01-24 09:53:13 +0900] [3088821] [INFO] Starting gunicorn 21.2.0
[2024-01-24 09:53:13 +0900] [3088821] [INFO] Listening at: http://0.0.0.0:8080 (3088821)
[2024-01-24 09:53:13 +0900] [3088821] [INFO] Using worker: gthread
[2024-01-24 09:53:13 +0900] [3088853] [INFO] Booting worker with pid: 3088853
/home/cbata/go/src/github.com/optuna/optuna-dashboard/venv/lib/python3.11/site-packages/optuna/study/_study_summary.py:115: FutureWarning: `system_attrs` has been deprecated in v3.1.0. The removal of this feature is currently scheduled for v5.0.0, but this schedule is subject to change. See https://github.com/optuna/optuna/releases/tag/v3.1.0.
  warnings.warn(
/home/cbata/go/src/github.com/optuna/optuna-dashboard/venv/lib/python3.11/site-packages/optuna/study/_study_summary.py:115: FutureWarning: `system_attrs` has been deprecated in v3.1.0. The removal of this feature is currently scheduled for v5.0.0, but this schedule is subject to change. See https://github.com/optuna/optuna/releases/tag/v3.1.0.
  warnings.warn(
/home/cbata/go/src/github.com/optuna/optuna-dashboard/venv/lib/python3.11/site-packages/optuna/study/_study_summary.py:115: FutureWarning: `system_attrs` has been deprecated in v3.1.0. The removal of this feature is currently scheduled for v5.0.0, but this schedule is subject to change. See https://github.com/optuna/optuna/releases/tag/v3.1.0.
  warnings.warn(

After

$ optuna-dashboard sqlite:///db.sqlite3 --host 0.0.0.0
[2024-01-24 10:06:20 +0900] [3096288] [INFO] Starting gunicorn 21.2.0
[2024-01-24 10:06:20 +0900] [3096288] [INFO] Listening at: http://0.0.0.0:8080 (3096288)
[2024-01-24 10:06:20 +0900] [3096288] [INFO] Using worker: gthread
[2024-01-24 10:06:20 +0900] [3096320] [INFO] Booting worker with pid: 3096320
[2024-01-24 10:06:52 +0900] [3096288] [INFO] Handling signal: winch

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ac1e1b6) 69.48% compared to head (06a0d5d) 69.50%.
Report is 36 commits behind head on main.

Files Patch % Lines
optuna_dashboard/artifact/_backend.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   69.48%   69.50%   +0.02%     
==========================================
  Files          35       35              
  Lines        2353     2358       +5     
==========================================
+ Hits         1635     1639       +4     
- Misses        718      719       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata merged commit 69ab4f0 into optuna:main Jan 24, 2024
13 checks passed
@c-bata c-bata deleted the remove-deprecation-warning branch January 24, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant