Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veena14cs
changed the title
rt4914
approved these changes
Feb 6, 2020
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayingFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
nikitamarysolomanpvt
approved these changes
Feb 10, 2020
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayingFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/home/continueplaying/ContinuePlayingItemViewModel.kt
Outdated
Show resolved
Hide resolved
PrarabdhGarg
pushed a commit
to PrarabdhGarg/oppia-android
that referenced
this pull request
Feb 12, 2020
…BindableAdapter usage. (oppia#641) * working on topic practice. * reverted * updated implementation * Update ContinuePlayingFragmentPresenter.kt * Update ContinuePlayingFragmentPresenter.kt * Update ContinuePlayingItemViewModel.kt * Delete OngoingListAdapter.kt * nit change * Update ContinuePlayViewModel.kt * fixed nit
rt4914
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Fix #572: Keyboard visible by default in Admin Pin (#573) * By default keyboard visibility issue in Admin Pin is resolved * Created a test case to check about Keyboard visibility by default in Admin Pin. * Test is modified with the suggested changes * Fix #577: Display profile name on navigation drawer. (#578) * display profile name in navigation drawer * Updated code implementation * adding tests * added testcases * Update NavigationDrawerFragmentPresenter.kt * updated nit changes. * Fix part #44: Full UI profile pin/password screen. (#597) * done ui corrections * fixed issues. * Update pin_password_activity.xml * updated color * updated icon * updated pinview shadow * updated icon color * changed shadow * updated mock color * fix * Update pin_password_activity.xml * updated nit change. * Update pin_password_activity.xml * removed fixed width * fixed dimen file changes * Update dimens.xml * Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. (#641) * working on topic practice. * reverted * updated implementation * Update ContinuePlayingFragmentPresenter.kt * Update ContinuePlayingFragmentPresenter.kt * Update ContinuePlayingItemViewModel.kt * Delete OngoingListAdapter.kt * nit change * Update ContinuePlayViewModel.kt * fixed nit * Add UI and finctionality for Switch Profile * Add UI Tests for switch profile option in navigation drawer * Add UI Tests for switch profile option in navigation drawer * Minor styling changes Co-authored-by: Akash Koradia <[email protected]> Co-authored-by: Veena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is replacing current recycler implementation with bindable adapter for ContinuePlaying.
Checklist