-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit all xml drawables files for Dark Mode audit #4960
Revisit all xml drawables files for Dark Mode audit #4960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning PTAL, Thanks.
As I talk to Rajat in chat and he said we only keep use of component_color in all xml files (include drawables, layouts) but except images, graphics, icons, vector assets and also add regex for all xml.
So in this PR I do all these things, and added separate regex check for drawables and layout. Is it fine?
Apologies @MohitGupta121 will need to look at this tomorrow. |
@BenHenning no problem totally fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121. This LGTM!
Unassigning @BenHenning since they have already approved the PR. |
Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Revisit all xml drawables files for Dark Mode audit:
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: