-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4850: Bump version codes for alpha 0.10 release, and fix version code ordering #4851
Conversation
@seanlip PTAL for codeowners. |
@BenHenning Not sure if I should merge this yet, feel free to do so once you're ready. Thanks! |
Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Also, bump version codes to prepare for another Kenya-specific alpha re-release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a self-review pass on the changes. I'll need to explain the changes in the main comment, as well, before this PR can be re-reviewed and merged.
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Also, fix the version code ordering for KitKat/Lollipop versions (Lollipop should always take priority).
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@seanlip PTAL for latest changes & PR description updates. I've also self-reviewed the latest changes, so I think this PR is ready to go if it looks good to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns on my end, thanks @BenHenning.
Explanation
Fixes #4850
This PR introduces the necessary version code updates for an upcoming 0.10 alpha release (2 different RCs). It also fixes the order of version codes such that less stable versions of the app (i.e. build flavors) take priority over more stable ones (so that users signed up for an earlier pre-release will get that over later versions, e.g. users would receive an alpha version of the app over beta if they're in both). This happens because Play Store uses version codes as the actual comparable versions for uploaded binaries, and it picks the binary with the highest version code to be installed based on all that a user may qualify for (based on which release tracks that they're participating in). The assumption here is that newer versions maintain backward compatibility with older versions, and this is something we will continue to aim for (though with minimal guarantees for pre-release versions).
Note that one unfortunate side effect of this change is that local installs of the app will require manually uninstalling when installing a "more stable" build flavor (though technically this was an issue in the other direction previously). This does make "upgrade" flows a little trickier to test locally unless using pre-assembled binaries.
This PR also updates app versioning such that the version now includes the local branch's commit rather than the common commit with develop (to ensure RC rebuilds have properly unique version names rather than sharing one version name for the release branch).
Essential Checklist
For UI-specific PRs only
N/A -- This is an infrastructure-only change.