Fixed #1956: Optimise Profile_chooser_add views

[Uticodes]

Explanation

Fix #1956: Optimise Profile_chooser_add views

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Screenshots Before	After
Mobile Portrait
Mobile Landscape
Tap Portrait
Tap Landscape
Tap LTR Portrait
Tap LTR Landscape
Mobile LTR Portrait
Mobile LTR Landscape

Accessibility Guide

TalkBack.Feature.mov

Unit Test Screenshot

[MohitGupta121]

@Uticodes please tag issue in both title and description like Fixed #[issue number]

[Uticodes]

okay, on it. thanks

…

On Sun, Dec 11, 2022 at 10:20 AM MOHIT GUPTA ***@***.***> wrote: @Uticodes <https://github.com/Uticodes> please tag issue in both title and description like Fixed #[issue number] — Reply to this email directly, view it on GitHub <#4785 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKMHQHGYTWMDH5GLTVRYMHTWMWMFVANCNFSM6AAAAAAS2QZTXQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Uticodes]

@Uticodes please tag issue in both title and description like Fixed #[issue number]

@MohitGupta121 Done

[chhabra-dhiraj]

@rt4914 Looks like this issue already has an ongoing PR but I cannot see any assignee. If this issue remains, I would like to take this up. Thanks!

[MohitGupta121]

@chhabra-dhiraj actually @Uticodes working on this issue #1956

[oppiabot]

Hi @Uticodes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[MohitGupta121]

@Uticodes are you still working on this PR?

[Uticodes]

Hi @MohitGupta121, I was still waiting for reviews but not gotten any till the bot closed the PR. Please what would you recommend I do now?

[MohitGupta121]

@Uticodes please first rebase your PR branch to upstream. After that we review it.

[Uticodes]

@Uticodes please first rebase your PR branch to upstream. After that we review it.

Alright, on it.

[MohitGupta121]

@Uticodes please push only the files you changed in your PR not all the files after rebase. It's making the PR too huge. See the file changes now is 190+ which is not correct.

[Uticodes]

@Uticodes please push only the files you changed in your PR not all the files after rebase. It's making the PR too huge. See the file changes now is 190+ which is not correct.

Yeah, fixing that now

[BenHenning]

I'll have to close this and you'll need to reopen a new PR @Uticodes since the PR was force-pushed. Please try to avoid situations where you need to force push the PR as it can break reviewer history and make reviewing much more difficult.

You can open a new PR that will have a clean commit & reviewer history.

[Uticodes]

I'll have to close this and you'll need to reopen a new PR @Uticodes since the PR was force-pushed. Please try to avoid situations where you need to force push the PR as it can break reviewer history and make reviewing much more difficult.

You can open a new PR that will have a clean commit & reviewer history.

Alright, will do that