-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #73: Add default configuration for CircleCI using Gradle #294
Conversation
changes to the gradlew script to resolve this non-typical path correctly).
See the CircleCI output--tests appear to be running correctly and reporting to GitHub. This won't be marked as a blocking check yet. We need to fix existing broken tests before we can do that. #295 is tracking this. |
Also, note that I'm not sure if Espresso is actually running here. I expect the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, thanks @BenHenning! Feel free to merge.
Thanks @seanlip. FYI @oppia/oppia-android that this is going in. It's not blocking, but you'll see it on your PRs. I'll make a broader announcement once this check is enforced. |
@BenHenning Thanks for the heads up. |
This fixes #73 by setting up CircleCI using Gradle. This configuration will need to change or we'll need to adopt a different service once #59 is resolved.
This includes adding the Gradle wrapper to a special .circleci directory for the specific purposes of .circleci (we do not include the Gradle wrapper in the top-level directory as is customary for Gradle projects).
gradlew
was generated by Gradle, but partially modified to support not being in the project root directory.