Fix #1769: Re-enable previously failing skipped tests (Espresso only) #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* testStateFragment_loadExp_continueToEndExploration_hasReturnToTopicButton() * testStateFragment_loadExp_changeConfiguration_continueToEnd_hasReturnToTopicButton() Leaving TODOs for oppia#1612 to fix them for Robolectric - similar TODOs are present for the parallel portrait tests.
yurilev
commented
Feb 10, 2021
| @@ -809,7 +808,7 @@ class StateFragmentTest { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("Currently failing due to a regression") // TODO(#1769): Re-enable. | |||
| @RunOn(TestPlatform.ESPRESSO) // TODO(#1612): Enable for Robolectric. | |||
There was a problem hiding this comment.
Note there are identical preexisting TODOs for adjacent tests, portrait versions of these two.
BenHenning
approved these changes
Feb 11, 2021
|
I titled it "fix part of" because at the time I thought the discussion might lead to more action items. Renamed the pull request to not say "part of". The tests are still disabled for Robolectric, but that is covered by the TODOs for #1612. |
yurilev
changed the title
|
Thanks @yurilev. SGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #1769: Re-enable previously failing skipped tests (Espresso only):
testStateFragment_loadExp_continueToEndExploration_hasReturnToTopicButton()testStateFragment_loadExp_changeConfiguration_continueToEnd_hasReturnToTopicButton()Tested on emulators locally.
Leaving TODOs for #1612 to fix them for Robolectric - similar TODOs are present for the parallel portrait tests.
Checklist