Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1871: Fix ProfileChooserFragmentTest for Robolectric #2045

Merged
merged 14 commits into from
Dec 7, 2020
Merged

Fix #1871: Fix ProfileChooserFragmentTest for Robolectric #2045

merged 14 commits into from
Dec 7, 2020

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Oct 26, 2020 •
edited
Loading

Explanation

Fix #1871

For Reviewers

Please check the comment below.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 marked this pull request as draft October 26, 2020 04:14
@BenHenning
Copy link
Member

@anandwana001 left a comment. Please let me know if you want to discuss further.

@rt4914 rt4914 removed their assignment Oct 27, 2020
@anandwana001 anandwana001 mentioned this pull request Nov 2, 2020
Closed
@anandwana001 anandwana001 marked this pull request as ready for review December 2, 2020 17:23
BenHenning
BenHenning requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001! Just a few comments.

@BenHenning BenHenning removed their assignment Dec 2, 2020
@BenHenning
Copy link
Member

@anandwana001 is this ready for another review?

@anandwana001
Copy link
Contributor Author

@anandwana001 is this ready for another review?

Yes, missed assigning last night.

BenHenning
BenHenning requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001. Left a few more comments. PTAL.

@BenHenning BenHenning assigned anandwana001 and unassigned BenHenning Dec 3, 2020
BenHenning
BenHenning approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001! Just one comment--PR overall LGTM. Please feel free to resolve my comment & merge after addressing it.

@BenHenning BenHenning removed their assignment Dec 5, 2020
@anandwana001 anandwana001 merged commit 893f017 into oppia:develop Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ProfileChooserFragmentTest for Robolectric
3 participants
@anandwana001 @BenHenning @rt4914