Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ProfileRenameFragment #3922

Closed
yash10019coder opened this issue Oct 12, 2021 · 0 comments · Fixed by #3947
Closed

Introduce ProfileRenameFragment #3922

yash10019coder opened this issue Oct 12, 2021 · 0 comments · Fixed by #3947
Assignees
@yash10019coder
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@yash10019coder
Copy link
Contributor

Creating a ProfileRenameFragment in the profile folder of the app module so that we can utilize the big tablet screen size by opening the fragment in a navhost fragment
This issue is a sub-issue of #3241
@yash10019coder yash10019coder self-assigned this Oct 12, 2021
@rt4914 rt4914 added this to the Beta milestone Oct 12, 2021
@yash10019coder yash10019coder mentioned this issue Oct 19, 2021
Merged
6 tasks
rt4914 pushed a commit that referenced this issue Dec 10, 2021
@yash10019coder
Fix #3922: Hi fi tablet create profile rename fragment (#3947)
4a897a1 
* added profile rename fragment in settings.profile

* reformatted ProfileRenameFragment.kt

* changed layout of profile_rename activities and fragment and created a Fragment Presenter

* Added logic for ProfileRenameFragment.kt and ProfileRenameFragmentPresenter.kt

* reformatted the Fragment and its presenter

* added fragment transaction in profile rename activity

* added fragment transaction in profile rename activity

* fixed profile_rename_activity.xml and its presenter.

* added ProfileRenameFragmentPresenter in test_file_exemptions.textproto

* added ProfileRenameFragment.kt in test_file_exemptions.textproto

* added Kdocs for the ProfileRenameFragment.kt and ProfileRenameFragmentPresenter.kt

* removed unused todo and its string

* formatted and removed unused code.

* removed unused imports in ProfileRenameActivityPresenter.kt

* created a new Test file ProfileRenameFragmentTest.kt and seperated the tests in it.

* removed unused imports.

* added profileId in the parameter of handleCreateView in ProfileRenameFragmentPresenter.kt.

* renamed the key properly

* renamed the comments properly.

* fixed failing test cases by adding profileHelperInitializer

* reformatted ProfileRenameFragmentTest.kt

* removed ProfileRenameFragment from test_file_exemptions.textproto.

* fixed layout and also rewritten the tests.

* added imports in lexicographic order.

* nit fixes.

* nit fixes.

* nit fixes.

* nit fixes.

* nit fixes.
@yash10019coder yash10019coder mentioned this issue Jun 14, 2022
Open
4 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash10019coder yash10019coder

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3922: Hi fi tablet create profile rename fragment yash10019coder/oppia-android
3 participants
@rt4914 @BenHenning @yash10019coder