Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: AudioFragment [Blocked: #162] #17

Closed
13 of 14 tasks
BenHenning opened this issue Aug 2, 2019 · 7 comments
Closed
13 of 14 tasks

Full UI: AudioFragment [Blocked: #162] #17

BenHenning opened this issue Aug 2, 2019 · 7 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019 •
edited by rt4914
Loading

Explanation

There needs to be a system for streaming and playing audio packs selected for a specific chapter by the user, leveraging the default audio language set for the current user's profile.

Low-fi Checklist

High-fi Checklist

  • Seekbar and its animation

Screenshot 2019-11-08 at 3 24 11 PM

  • AudioBar along with Volume icon in toolbar

Screenshot 2019-11-08 at 3 24 37 PM

  • CellularAlertDialog

Screenshot 2019-11-08 at 3 24 58 PM

  • LanguageChangeDialog

Screenshot 2019-11-08 at 3 24 45 PM

  • Final touch including animations, positioning and Accessibility checks

Test follow items too

  • Check how to audio bar changes on en and hi-en because this might change the seekbar length.
  • Shadow below the seekbar thumb (green circle)
  • The seekbar progress - white line has a sort of padding at start/end which needs to be removed.
  • The seekbar white progress line should be rounded at the end
  • [ ]After the volume icon click, the “Language string like HI or EN” takes time to be visible which is not good for the UI.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #5.

@BenHenning
Copy link
Member Author

It's not yet clear if we'll actually be persisting the audio files on disk, or if this will use the data source interface to expose the audio data.

@BenHenning BenHenning mentioned this issue Aug 2, 2019
Closed
@BenHenning BenHenning changed the title Audio player Audio player [Blocked: #5] Aug 12, 2019
@jamesxu0
Copy link
Contributor

jamesxu0 commented Sep 12, 2019 •
edited
Loading

https://medium.com/androiddevelopers/building-a-simple-audio-app-in-android-part-1-3-c14d1a66e0f1

I found this articles for building a simple media player, which I'm going to base my implementation off of. I guess I'm confused on how to structure the code because the audio player should be a reusable component since it's used in a lot of places. It should be constructed with an audio source then the UI interacts with that source. I'm not sure if this should be a custom view, small fragment, or something else. Also, will the audio be from a uri?

@BenHenning BenHenning changed the title Audio player [Blocked: #5] Audio player Sep 17, 2019
@BenHenning BenHenning mentioned this issue Sep 18, 2019
Closed
@BenHenning BenHenning changed the title Audio player Implement the high fidelity UI for the audio bar Sep 18, 2019
rt4914 added a commit that referenced this issue Sep 19, 2019
@rt4914
Fix part of #17: Exploration Player Audio Component (Part 4) (#105)
4711fd5 
* Exploration Player base code for activity and fragment

* Fake Data Provider

* Base code for audio player

* XML code and resources for audio component

* LanguageDialogFragment added

* Language Interface code

* Nit changes mainly in documentation

* Nit changes mainly in documentation for State too

* Changed Controller to Presenter and optimised the fragment transaction code

* Basic code for ExporationActivityTest

* ExplorationActivity dummy test

* Nit changes like naming and spacing and comments

* Nit changes to audio fragment in xml files and java

* Audio language selection

* Removed logs, and improvised fragment code

* Removed unused imports

* Changes to LanguageFragment but still not perfect

* ViewModel and Fragment changes

* Nit changes

* Nit changes in javadoc and unused imports

* LanguageInterface along with its usage

* Nit changes
@BenHenning BenHenning changed the title Implement the high fidelity UI for the audio bar Full UI: AudioFragment [Blocked: #116, #162] Sep 20, 2019
@BenHenning
Copy link
Member Author

BenHenning commented Sep 20, 2019 •
edited
Loading

This is technically blocked on #116 and #162.

@BenHenning BenHenning changed the title Full UI: AudioFragment [Blocked: #116, #162] Full UI: AudioFragment [Blocked: #116, #123, #162] Sep 20, 2019
@BenHenning BenHenning changed the title Full UI: AudioFragment [Blocked: #116, #123, #162] Full UI: AudioFragment [Blocked: #116, #162] Sep 20, 2019
@BenHenning
Copy link
Member Author

@jamesxu0: yep, audio will come from a URI.

@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
@jamesxu0 jamesxu0 mentioned this issue Sep 27, 2019
Merged
6 tasks
@BenHenning BenHenning changed the title Full UI: AudioFragment [Blocked: #116, #162] Full UI: AudioFragment [Blocked: #162] Sep 30, 2019
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Oct 20, 2019
@jamesxu0 jamesxu0 mentioned this issue Nov 6, 2019
Closed
10 tasks
@rt4914
Copy link
Contributor

rt4914 commented Nov 8, 2019

@jamesxu0 can you please verify what all has been finished in the above low-fi checklist.

@rt4914 rt4914 mentioned this issue Nov 14, 2019
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Nov 14, 2019
@rt4914 @BenHenning
Fix part of #17: Hifi audio bar basic and fix story crash (#347)
9c57d1a 
* Nit changes

* Audio UI changes

* Fix off-by-one on iterated story range.
Merged
10 tasks
nikitamarysolomanpvt added a commit that referenced this issue Nov 26, 2019
@nikitamarysolomanpvt
Fix part #17,#382: Hi fi topic audio bar (#467)
b5bc32b 
As per the verbal discussion the audio bar was not playable in android API 19 and lowfi issue.

* thumb seekbar

* shadow to audio bar

* audio bar width as per screen width

* audio bar width as per screen width

* play and pause icons size
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. and removed Workstream: Highfi UI Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jun 23, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jun 24, 2020

The only work item pending in this is #1383

Rest all have been fixed via different PRs in #467 #495 #358 #356

@rt4914 rt4914 closed this as completed Jun 24, 2020
@yash10019coder yash10019coder mentioned this issue Sep 13, 2021
Open
4 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @jamesxu0