Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-profile data storage system #14

Closed
BenHenning opened this issue Aug 2, 2019 · 5 comments
Closed

Per-profile data storage system #14

BenHenning opened this issue Aug 2, 2019 · 5 comments
Assignees
@jamesxu0
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Individual profiles will need to have data associated with them directly. Such data requires a system to organize other file I/O systems based on the current profile that's selected. This system should interop directly with the other I/O systems described above rather than reimplement them. One possible manifestation of this might be a series of providers for the other I/O systems based on profile ID.

Note that this system is not responsible for managing the current profile logged in, though it should be designed with per-profile Takeout/Wipeout in mind.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This involves changing the sqlite and the persistent cache system. For that reason, this is blocked by #12 and #7.

This was referenced Aug 2, 2019
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 2, 2019
Open
Open
Closed
@BenHenning BenHenning changed the title Per-profile data storage system Per-profile data storage system [Blocked: #7, #12] Aug 12, 2019
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Sep 9, 2019
@BenHenning BenHenning changed the title Per-profile data storage system [Blocked: #7, #12] Per-profile data storage system [Blocked: #12] Sep 17, 2019
@BenHenning BenHenning changed the title Per-profile data storage system [Blocked: #12] Per-profile data storage system Sep 17, 2019
@BenHenning
Copy link
Member Author

NB: This is not blocked on #12 since for the prototype only the proto-based cache store is used for storage, so only that needs to be made per-profile.

@BenHenning
Copy link
Member Author

BenHenning commented Sep 17, 2019 •
edited
Loading

This issue includes adding per-profile support for existing essential data stores, such as #14 and #15.

@BenHenning BenHenning modified the milestones: Prototype -- Infra, Minimal Viable Product Oct 6, 2019
@jamesxu0 jamesxu0 self-assigned this Oct 22, 2019
@BenHenning BenHenning modified the milestones: Minimal Viable Product, Global Availability, Beta Jun 23, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jan 13, 2021

@BenHenning Is this done ? Or can anyone work on this?

@BenHenning
Copy link
Member Author

This is finished: https://github.com/oppia/oppia-android/blob/develop/data/src/main/java/org/oppia/android/data/persistence/PersistentCacheStore.kt#L308.

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @jamesxu0