Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow out of order deprecate #688

Merged

Conversation

ankitathomas
Copy link
Contributor

This change allows deprecator to ignore missing bundles, which are checked for with #656.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #688 (098b0c7) into master (fd09951) will decrease coverage by 0.60%.
The diff coverage is 70.75%.

❗ Current head 098b0c7 differs from pull request most recent head 1d6c7e2. Consider uploading reports for the commit 1d6c7e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   48.98%   48.38%   -0.61%     
==========================================
  Files          91       94       +3     
  Lines        7869     8066     +197     
==========================================
+ Hits         3855     3903      +48     
- Misses       3252     3407     +155     
+ Partials      762      756       -6     
Impacted Files Coverage Δ
internal/action/init.go 100.00% <ø> (ø)
pkg/registry/bundle.go 58.10% <0.00%> (ø)
pkg/registry/populator.go 63.04% <0.00%> (+1.40%) ⬆️
pkg/sqlite/deprecate.go 0.00% <0.00%> (ø)
pkg/sqlite/load.go 34.47% <0.00%> (+0.23%) ⬆️
pkg/registry/types.go 18.57% <14.28%> (+3.86%) ⬆️
internal/action/render.go 43.08% <50.00%> (ø)
pkg/lib/registry/registry.go 13.33% <65.38%> (ø)
internal/property/property.go 97.81% <66.66%> (+2.06%) ⬆️
pkg/registry/decode.go 77.27% <66.66%> (-3.98%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d4c54...1d6c7e2. Read the comment docs.

Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas ankitathomas requested a review from dinhxuanvu June 23, 2021 20:58
@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@exdx
Copy link
Member

exdx commented Jun 24, 2021

/lgtm
/override codecov/project

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@exdx: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • codecov/project

Only the following contexts were expected:

  • tide

In response to this:

/lgtm
/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6ebda78 into operator-framework:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants