Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example bundle dockerfile so that it copies the manifests folder #668

Conversation

erdii
Copy link
Contributor

@erdii erdii commented May 27, 2021

Description of the change:
fix example bundle dockerfile

pre-fix this would copy all yaml files in ./manifests into the file
/manifests and it would only keep the last file's contents.

Adding that trailing slash properly creates the /manifests directory and copies
all files as expected.

Motivation for the change:

I tried to generate an index image from such a broken bundle image and even first suspected #603.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Sorry, something went wrong.

@openshift-ci openshift-ci bot requested review from kevinrizza and timflannagan May 27, 2021 13:37
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2021

Hi @erdii. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
erdii Josh Gwosdz
pre-fix this would copy all yaml files in `./manifests` into the _file_
`/manifests` and it would only keep the last file's contents.

Adding that trailing slash creates the `/manifests` directory and copies
all files as expected.

Signed-off-by: Josh Gwosdz <[email protected]>
@erdii erdii force-pushed the fix-example-bundle-dockerfile branch from 27efaee to edb64dd Compare May 27, 2021 13:40
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #668 (edb64dd) into master (92e5523) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   48.71%   48.70%   -0.02%     
==========================================
  Files          88       88              
  Lines        7673     7673              
==========================================
- Hits         3738     3737       -1     
- Misses       3200     3201       +1     
  Partials      735      735              
Impacted Files Coverage Δ
pkg/registry/query.go 61.07% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e5523...edb64dd. Read the comment docs.

@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@timflannagan
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2021
@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erdii, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit f1629cd into operator-framework:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants