-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix example bundle dockerfile so that it copies the manifests folder #668
fix example bundle dockerfile so that it copies the manifests folder #668
Conversation
Hi @erdii. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pre-fix this would copy all yaml files in `./manifests` into the _file_ `/manifests` and it would only keep the last file's contents. Adding that trailing slash creates the `/manifests` directory and copies all files as expected. Signed-off-by: Josh Gwosdz <[email protected]>
27efaee
to
edb64dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
- Coverage 48.71% 48.70% -0.02%
==========================================
Files 88 88
Lines 7673 7673
==========================================
- Hits 3738 3737 -1
- Misses 3200 3201 +1
Partials 735 735
Continue to review full report at Codecov.
|
/lgtm |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erdii, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
fix example bundle dockerfile
pre-fix this would copy all yaml files in
./manifests
into the file/manifests
and it would only keep the last file's contents.Adding that trailing slash properly creates the
/manifests
directory and copiesall files as expected.
Motivation for the change:
I tried to generate an index image from such a broken bundle image and even first suspected #603.
Reviewer Checklist
/docs