Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force latest install of podman to fix currently broken e2e tests #645

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

joelanford
Copy link
Member

Signed-off-by: Joe Lanford [email protected]

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
joelanford Joe Lanford
Signed-off-by: Joe Lanford <[email protected]>
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #645 (05de87b) into master (0a0282b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
- Coverage   48.40%   48.38%   -0.02%     
==========================================
  Files          87       87              
  Lines        7599     7599              
==========================================
- Hits         3678     3677       -1     
- Misses       3195     3196       +1     
  Partials      726      726              
Impacted Files Coverage Δ
pkg/registry/query.go 61.07% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0282b...05de87b. Read the comment docs.

@timflannagan
Copy link
Member

/lgtm

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, dinhxuanvu, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@dinhxuanvu dinhxuanvu merged commit a8d172d into operator-framework:master Apr 27, 2021
@joelanford joelanford deleted the fix-e2e-podman branch April 27, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants