Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: Fix the podman installation in the e2e tests #635

Conversation

timflannagan
Copy link
Member

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #635 (b790082) into master (4078f47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   48.22%   48.22%           
=======================================
  Files          87       87           
  Lines        7592     7592           
=======================================
  Hits         3661     3661           
  Misses       3208     3208           
  Partials      723      723           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4078f47...b790082. Read the comment docs.

@timflannagan timflannagan force-pushed the fix-podman-installation branch from 019daea to eb9b38f Compare April 14, 2021 20:09
Comment on lines +47 to +48
sudo apt-get -y update
podman version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: whether this was a one-off, but adding the sudo apt-get -y install podman here as well resulted in an e2e failure as we attempted to delete a container, which wasn't possible due to device or resource busy. Keeping this iteration for now, as we can rely on the podman version (3.0.0) we get by default in the ubuntu LTS release.

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@timflannagan
Copy link
Member Author

????

codecov/project 48.20% (-0.02%) compared to 4078f47

@exdx
Copy link
Member

exdx commented Apr 14, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
I'm not sure why this is needed when diving into the minikube
documentation - maybe this is a requirement of an older minikube version
- and that the `none` driver should just be able to autodetect the local
docker registry w/o any explicit bash environment variables being
exported by that command.

This was producing the following error in the e2e-minikube job logs:

```bash
X Exiting due to ENV_DRIVER_CONFLICT: 'none' driver does not support 'minikube docker-env' command
```

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the fix-podman-installation branch from eb9b38f to b790082 Compare April 14, 2021 20:25
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@timflannagan timflannagan added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@timflannagan
Copy link
Member Author

(force pushed with lease so hopefully the codecov/project check stops complaining)

@openshift-merge-robot openshift-merge-robot merged commit 0153d70 into operator-framework:master Apr 14, 2021
@timflannagan timflannagan deleted the fix-podman-installation branch April 14, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants