-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: Fix the podman installation in the e2e tests #635
.github/workflows: Fix the podman installation in the e2e tests #635
Conversation
c32e1e2
to
019daea
Compare
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 48.22% 48.22%
=======================================
Files 87 87
Lines 7592 7592
=======================================
Hits 3661 3661
Misses 3208 3208
Partials 723 723 Continue to review full report at Codecov.
|
019daea
to
eb9b38f
Compare
sudo apt-get -y update | ||
podman version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: whether this was a one-off, but adding the sudo apt-get -y install podman
here as well resulted in an e2e failure as we attempted to delete a container, which wasn't possible due to device or resource busy
. Keeping this iteration for now, as we can rely on the podman version (3.0.0) we get by default in the ubuntu LTS release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
????
|
/lgtm |
Signed-off-by: timflannagan <[email protected]>
I'm not sure why this is needed when diving into the minikube documentation - maybe this is a requirement of an older minikube version - and that the `none` driver should just be able to autodetect the local docker registry w/o any explicit bash environment variables being exported by that command. This was producing the following error in the e2e-minikube job logs: ```bash X Exiting due to ENV_DRIVER_CONFLICT: 'none' driver does not support 'minikube docker-env' command ``` Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
eb9b38f
to
b790082
Compare
New changes are detected. LGTM label has been removed. |
(force pushed with lease so hopefully the codecov/project check stops complaining) |
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs