feat(cmd): Add validate subcommand to opm cmd to validate config files #618

dinhxuanvu · 2021-03-31T18:18:36Z

Description of the change:
Validate declarative config (JSON) files in a given directory. The validation
is using the validation library from declcfg, model and property packages.

Signed-off-by: Vu Dinh [email protected]
Motivation for the change:
Allow users to validate their config files.

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

codecov · 2021-03-31T19:46:55Z

Codecov Report

Merging #618 (a4520ff) into master (3bc6bf5) will decrease coverage by 0.06%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   52.16%   52.10%   -0.07%     
==========================================
  Files          81       81              
  Lines        6397     6403       +6     
==========================================
- Hits         3337     3336       -1     
- Misses       2403     2409       +6     
- Partials      657      658       +1

Impacted Files	Coverage Δ
internal/declcfg/declcfg_to_model.go	`86.76% <80.00%> (-10.12%)`	⬇️
internal/model/model.go	`91.66% <100.00%> (+0.14%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc6bf5...a4520ff. Read the comment docs.

pkg/lib/config/validate.go

cmd/opm/validate/validate.go

pkg/lib/config/validate.go

timflannagan · 2021-04-08T15:43:48Z

LGTM but holding for someone that's more up-to-date on this effort.

/lgtm
/hold

dinhxuanvu · 2021-04-08T15:51:35Z

Folks, please feel free to lgtm and approve but keep the hold in for now. We try to line up the 3 config PRs for merging today and this one should go last to avoid unnecessary rebase. Thanks.

openshift-ci · 2021-04-08T16:47:59Z

@dinhxuanvu: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`dd63253`	link	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ecordell · 2021-04-08T20:39:09Z

/approve

openshift-ci-robot · 2021-04-08T20:39:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-04-09T12:34:12Z

@dinhxuanvu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Validate declarative config (JSON) files in a given directory. The validation is using the validation library from declcfg, model and property packages. Signed-off-by: Vu Dinh <[email protected]>

dinhxuanvu · 2021-04-09T14:14:48Z

/hold cancel

cmd/opm/root/cmd.go

cmd/opm/validate/validate.go

1. Missing `defaultChannel` doesn’t get caught and error out as an empty channel issue which is incorrect. 2. Missing `package` property will result out of bound error 3. Bundles without channel is allowed which will lead to orphaned bundles 4. Bundle without a bundle image is valid when it shouldn’t be. Bundle must either have bundle image or bundle data (objects). Signed-off-by: Vu Dinh <[email protected]>

anik120 · 2021-04-09T14:34:32Z

/lgtm

joelanford · 2021-04-09T15:05:10Z

/lgtm
/override codecov/project

openshift-ci-robot · 2021-04-09T15:05:11Z

@joelanford: /override requires a failed status context to operate on.
The following unknown contexts were given:

codecov/project

Only the following contexts were expected:

tide

In response to this:

/lgtm
/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-04-09T15:08:26Z

/override codecov/patch
/override codecov/project

timflannagan · 2021-04-09T15:09:57Z

Hmm, it looks like it's possible to override but you may need higher permissions: #611 (comment)?

openshift-ci-robot · 2021-04-09T15:10:30Z

@timflannagan: /override requires a failed status context to operate on.
The following unknown contexts were given:

codecov/patch
codecov/project

Only the following contexts were expected:

tide

In response to this:

/override codecov/patch
/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2021-04-09T15:14:01Z

/override codecov/project

openshift-ci-robot · 2021-04-09T15:14:03Z

@dinhxuanvu: /override requires a failed status context to operate on.
The following unknown contexts were given:

codecov/project

Only the following contexts were expected:

tide

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2021-04-09T15:17:16Z

The PR passed all tests so manually merge this to bypass the codecov.

dinhxuanvu requested review from ecordell, joelanford and anik120 March 31, 2021 18:18

openshift-ci-robot requested review from ankitathomas and benluddy March 31, 2021 18:18

openshift-ci-robot added the approved label Mar 31, 2021

dinhxuanvu force-pushed the declcfg-validate branch from 663ea66 to 29720d7 Compare April 1, 2021 05:20

anik120 reviewed Apr 6, 2021

View reviewed changes

pkg/lib/config/validate.go Outdated Show resolved Hide resolved

dinhxuanvu force-pushed the declcfg-validate branch 5 times, most recently from 1bfdc95 to 81bea83 Compare April 8, 2021 04:27

dinhxuanvu changed the title ~~feat(cmd): Add validate subcommand to index cmd to validate config files~~ feat(cmd): Add validate subcommand to opm cmd to validate config files Apr 8, 2021

timflannagan reviewed Apr 8, 2021

View reviewed changes

cmd/opm/validate/validate.go Outdated Show resolved Hide resolved

timflannagan reviewed Apr 8, 2021

View reviewed changes

cmd/opm/validate/validate.go Outdated Show resolved Hide resolved

timflannagan reviewed Apr 8, 2021

View reviewed changes

cmd/opm/validate/validate.go Show resolved Hide resolved

timflannagan reviewed Apr 8, 2021

View reviewed changes

pkg/lib/config/validate.go Show resolved Hide resolved

dinhxuanvu force-pushed the declcfg-validate branch from 81bea83 to dd63253 Compare April 8, 2021 15:05

openshift-ci-robot added the do-not-merge/hold label Apr 8, 2021

openshift-ci-robot assigned timflannagan Apr 8, 2021

openshift-ci-robot added the lgtm label Apr 8, 2021

dinhxuanvu added the feat/declarative-config label Apr 8, 2021

joelanford mentioned this pull request Apr 8, 2021

Implement registry server for declarative config #601

Merged

5 tasks

openshift-ci-robot added the needs-rebase label Apr 9, 2021

feat(validate): Add opm validate cmd to validate config files

e50cfdd

Validate declarative config (JSON) files in a given directory. The validation is using the validation library from declcfg, model and property packages. Signed-off-by: Vu Dinh <[email protected]>

dinhxuanvu force-pushed the declcfg-validate branch from dd63253 to 43bdcdd Compare April 9, 2021 14:07

openshift-ci-robot removed the lgtm label Apr 9, 2021

openshift-ci-robot removed the do-not-merge/hold label Apr 9, 2021

anik120 reviewed Apr 9, 2021

View reviewed changes

cmd/opm/root/cmd.go Outdated Show resolved Hide resolved

cmd/opm/validate/validate.go Show resolved Hide resolved

dinhxuanvu force-pushed the declcfg-validate branch from 43bdcdd to a4520ff Compare April 9, 2021 14:32

openshift-ci-robot assigned anik120 Apr 9, 2021

openshift-ci-robot added the lgtm label Apr 9, 2021

dinhxuanvu removed the needs-rebase label Apr 9, 2021

openshift-ci-robot assigned joelanford Apr 9, 2021

dinhxuanvu merged commit 1b885c5 into operator-framework:master Apr 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cmd): Add validate subcommand to opm cmd to validate config files #618

feat(cmd): Add validate subcommand to opm cmd to validate config files #618

dinhxuanvu commented Mar 31, 2021

codecov bot commented Mar 31, 2021 •

edited

Loading

timflannagan commented Apr 8, 2021

dinhxuanvu commented Apr 8, 2021

openshift-ci bot commented Apr 8, 2021

ecordell commented Apr 8, 2021

openshift-ci-robot commented Apr 8, 2021

openshift-ci-robot commented Apr 9, 2021

dinhxuanvu commented Apr 9, 2021

anik120 commented Apr 9, 2021

joelanford commented Apr 9, 2021

openshift-ci-robot commented Apr 9, 2021

timflannagan commented Apr 9, 2021

timflannagan commented Apr 9, 2021

openshift-ci-robot commented Apr 9, 2021

dinhxuanvu commented Apr 9, 2021

openshift-ci-robot commented Apr 9, 2021

dinhxuanvu commented Apr 9, 2021

feat(cmd): Add validate subcommand to opm cmd to validate config files #618

feat(cmd): Add validate subcommand to opm cmd to validate config files #618

Conversation

dinhxuanvu commented Mar 31, 2021

codecov bot commented Mar 31, 2021 • edited Loading

Codecov Report

timflannagan commented Apr 8, 2021

dinhxuanvu commented Apr 8, 2021

openshift-ci bot commented Apr 8, 2021

ecordell commented Apr 8, 2021

openshift-ci-robot commented Apr 8, 2021

openshift-ci-robot commented Apr 9, 2021

dinhxuanvu commented Apr 9, 2021

anik120 commented Apr 9, 2021

joelanford commented Apr 9, 2021

openshift-ci-robot commented Apr 9, 2021

timflannagan commented Apr 9, 2021

timflannagan commented Apr 9, 2021

openshift-ci-robot commented Apr 9, 2021

dinhxuanvu commented Apr 9, 2021

openshift-ci-robot commented Apr 9, 2021

dinhxuanvu commented Apr 9, 2021

codecov bot commented Mar 31, 2021 •

edited

Loading