Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add a sanity check for Go packages #596

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/api/grpc_health_v1/health.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/api/grpc_health_v1/health_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/api/registry.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/api/registry_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/image/containerdregistry/resolver.go
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ func NewResolver(configDir string, insecure bool, roots *x509.CertPool) (remotes
ExpectContinueTimeout: 5 * time.Second,
TLSClientConfig: &tls.Config{
InsecureSkipVerify: false,
RootCAs: roots,
RootCAs: roots,
},
}

@@ -60,7 +60,7 @@ func NewResolver(configDir string, insecure bool, roots *x509.CertPool) (remotes
}

opts := docker.ResolverOptions{
Hosts: docker.ConfigureDefaultRegistries(regopts...),
Hosts: docker.ConfigureDefaultRegistries(regopts...),
Headers: headers,
}

1 change: 0 additions & 1 deletion pkg/image/registry.go
Original file line number Diff line number Diff line change
@@ -29,4 +29,3 @@ type Registry interface {
// If it exists, it's used as the base image.
// Pack(ctx context.Context, ref Reference, from io.Reader) (next string, err error)
}

2 changes: 1 addition & 1 deletion pkg/lib/bundle/interfaces.go
Original file line number Diff line number Diff line change
@@ -25,6 +25,6 @@ func NewImageValidator(registry image.Registry, logger *logrus.Entry, options ..
return imageValidator{
registry: registry,
logger: logger,
optional: options,
optional: options,
}
}
3 changes: 2 additions & 1 deletion pkg/lib/dns/nsswitch_test.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package dns

import (
"github.com/stretchr/testify/require"
"io/ioutil"
"os"
"testing"

"github.com/stretchr/testify/require"
)

func TestEnsureNsswitch(t *testing.T) {
2 changes: 1 addition & 1 deletion pkg/lib/indexer/indexer_test.go
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ func TestGetBundlesToExport(t *testing.T) {
t.Fatalf("creating querier: %s", err)
}

bundleMap, err := getBundlesToExport(dbQuerier, []string {"etcd"})
bundleMap, err := getBundlesToExport(dbQuerier, []string{"etcd"})
if err != nil {
t.Fatalf("exporting bundles from db: %s", err)
}
61 changes: 31 additions & 30 deletions pkg/registry/bundlegraphloader_test.go
Original file line number Diff line number Diff line change
@@ -2,9 +2,10 @@ package registry

import (
"encoding/json"
"github.com/blang/semver"
"testing"

"github.com/blang/semver"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
@@ -315,55 +316,55 @@ func TestBundleGraphLoader(t *testing.T) {
}

func TestIsSkipPatchCandidate(t *testing.T) {
tests := []struct{
name string
added string
compare string
expected bool
tests := []struct {
name string
added string
compare string
expected bool
commutative bool
}{
{
name: "equal versions",
added: "0.0.0",
compare: "0.0.0",
expected: false,
name: "equal versions",
added: "0.0.0",
compare: "0.0.0",
expected: false,
commutative: true,
},
{
name: "do not accept different major/minor version",
added: "0.1.0",
compare: "0.2.0",
expected: false,
name: "do not accept different major/minor version",
added: "0.1.0",
compare: "0.2.0",
expected: false,
commutative: true,
},
{
name: "accept larger patch version",
added: "0.0.1",
compare: "0.0.0",
name: "accept larger patch version",
added: "0.0.1",
compare: "0.0.0",
expected: true,
},
{
name: "accept patch version without pre-release",
added: "0.0.0",
compare: "0.0.0-1",
name: "accept patch version without pre-release",
added: "0.0.0",
compare: "0.0.0-1",
expected: true,
},
{
name: "accept longer pre-release with same prefix",
added: "0.0.1-1.2",
compare: "0.0.1-1",
name: "accept longer pre-release with same prefix",
added: "0.0.1-1.2",
compare: "0.0.1-1",
expected: true,
},
{
name: "accept numerically larger pre-release",
added: "0.0.1-11",
compare: "0.0.1-2",
name: "accept numerically larger pre-release",
added: "0.0.1-11",
compare: "0.0.1-2",
expected: true,
},
{
name: "accept lexicographically larger pre-release",
added: "0.0.1-beta.1",
compare: "0.0.1-alpha.1",
name: "accept lexicographically larger pre-release",
added: "0.0.1-beta.1",
compare: "0.0.1-alpha.1",
expected: true,
},
}
@@ -382,4 +383,4 @@ func TestIsSkipPatchCandidate(t *testing.T) {
}
})
}
}
}
2 changes: 1 addition & 1 deletion pkg/registry/csv_test.go
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"k8s.io/apimachinery/pkg/apis/meta/v1"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

func TestClusterServiceVersion_GetApiServiceDefinitions(t *testing.T) {
7 changes: 4 additions & 3 deletions pkg/registry/decode_test.go
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
package registry

import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"io"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"os"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
)

func TestDecodeUnstructured(t *testing.T) {
2 changes: 1 addition & 1 deletion pkg/server/server.go
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ type RegistryServer struct {
var _ api.RegistryServer = &RegistryServer{}

func NewRegistryServer(store registry.Query) *RegistryServer {
return &RegistryServer{UnimplementedRegistryServer: api.UnimplementedRegistryServer{}, store: store}
return &RegistryServer{UnimplementedRegistryServer: api.UnimplementedRegistryServer{}, store: store}
}

func (s *RegistryServer) ListPackages(req *api.ListPackageRequest, stream api.Registry_ListPackagesServer) error {
6 changes: 3 additions & 3 deletions pkg/sqlite/db.go
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@ package sqlite

import (
"database/sql"

_ "github.com/mattn/go-sqlite3"
)

@@ -19,11 +20,10 @@ func OpenReadOnly(fileName string) (*sql.DB, error) {
// EnableForeignKeys appends the option to enable foreign keys on connections
// note that without this option, PRAGMAs about foreign keys will lie.
func EnableForeignKeys(fileName string) string {
return "file:"+fileName+"?_foreign_keys=on"
return "file:" + fileName + "?_foreign_keys=on"
}

// Immutable appends the option to mark the db immutable on connections
func EnableImmutable(fileName string) string {
return "file:"+fileName+"?immutable=true"
return "file:" + fileName + "?immutable=true"
}

1 change: 1 addition & 0 deletions pkg/sqlite/migrations/006_associate_apis_with_bundle.go
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@ package migrations
import (
"context"
"database/sql"

"github.com/operator-framework/operator-registry/pkg/registry"
)

3 changes: 2 additions & 1 deletion pkg/sqlite/migrations/006_associate_apis_with_bundle_test.go
Original file line number Diff line number Diff line change
@@ -4,9 +4,10 @@ import (
"context"
"database/sql"
"fmt"
"github.com/operator-framework/operator-registry/pkg/registry"
"testing"

"github.com/operator-framework/operator-registry/pkg/registry"

"github.com/stretchr/testify/require"

"github.com/operator-framework/operator-registry/pkg/sqlite/migrations"
3 changes: 2 additions & 1 deletion pkg/sqlite/remove_test.go
Original file line number Diff line number Diff line change
@@ -2,9 +2,10 @@ package sqlite

import (
"context"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"testing"

"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"

"github.com/operator-framework/operator-registry/pkg/image"
"github.com/operator-framework/operator-registry/pkg/registry"

6 changes: 3 additions & 3 deletions tools.go
Original file line number Diff line number Diff line change
@@ -3,9 +3,9 @@
package tools

import (
_ "google.golang.org/protobuf/cmd/protoc-gen-go"
_ "google.golang.org/grpc/cmd/protoc-gen-go-grpc"
_ "github.com/grpc-ecosystem/grpc-health-probe"
_ "github.com/maxbrunsfeld/counterfeiter/v6"
_ "github.com/onsi/ginkgo/ginkgo"
)
_ "google.golang.org/grpc/cmd/protoc-gen-go-grpc"
_ "google.golang.org/protobuf/cmd/protoc-gen-go"
)