-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate initializer and registry-server #587
Conversation
Per a discussion on the olm-dev triage call on Feb 4th, it was agreed that both the `initializer` and `registry-server` binaries should be deprecated in favor of `opm` equivalent commands.
Hi @cdjohnson. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 90 90
Lines 6276 6276
=======================================
Hits 3063 3063
Misses 2528 2528
Partials 685 685 Continue to review full report at Codecov.
|
/ok-to-test |
@cdjohnson: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdjohnson, dinhxuanvu, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
Per a discussion on the olm-dev triage call on Feb 4th, it was agreed that both the
initializer
andregistry-server
binaries should be deprecated in favor ofopm
equivalent commands.Motivation for the change:
The
registry-server
is redundant and is no longer used in mainstream catalog index images, AFAIK.The
initializer
approach doesn't usebundle images
which is not strategic, which also requires the sqlite database to encode the entire CSV and Manifests and doesn't work well with the upcoming declarative index feature.Reviewer Checklist
/docs