fix(opm-index-add) Throw error when a bundle is invalid #522
Conversation
With the introduction of operator-framework#503, when a bundle from the list of bundles being added with the `opm index add` command was invalid, opm was not throwing an error, and was building the index with the valid bundles instead, even when the `permissive` mode was not enabled. This PR fixes the issue.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anik120 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -142,7 +142,7 @@ func (r *ReplacesInputStream) Next() (*ImageInput, error) { | |||
| delete(r.packages, pkg) | |||
| } | |||
|
|
|||
| return image, nil | |||
| return image, utilerrors.NewAggregate(errs) | |||
There was a problem hiding this comment.
Should we add packageErrs into the errs before return?
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
=======================================
Coverage 49.42% 49.42%
=======================================
Files 90 90
Lines 6286 6286
=======================================
Hits 3107 3107
Misses 2485 2485
Partials 694 694
Continue to review full report at Codecov.
|
| @@ -142,7 +142,7 @@ func (r *ReplacesInputStream) Next() (*ImageInput, error) { | |||
| delete(r.packages, pkg) | |||
| } | |||
|
|
|||
| return image, nil | |||
| return image, utilerrors.NewAggregate(errs) | |||
There was a problem hiding this comment.
this fix looks incorrect -- the way this should work is:
- as long as we find a bundle that works for at least one package, return that "good" bundle and no error
- if there are no "good" bundles left, return errors from bad bundles
- if there are no bundles left, we're good, return nil
|
Closing in favor of #523 |
Description of the change:
With the introduction of #503, when a bundle from the list of bundles
being added with the
opm index addcommand was invalid, opm was notthrowing an error, and was building the index with the valid bundles
instead, even when the
permissivemode was not enabled. This PRfixes the issue.
Motivation for the change:
Reviewer Checklist
/docs