-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the description of validation "RegistryV1" format #480
fix the description of validation "RegistryV1" format #480
Conversation
Signed-off-by: dongwenjuan <[email protected]>
Hi @dongwenjuan. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @ankitathomas |
@dongwenjuan we appreciate you taking the time to make this change, but for future reference, we typically hold off on including such small doc/style changes until we have a more substantive patch that we can include them in. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dongwenjuan, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK, thanks~ |
Docs only, bypassing infra issues for this one. /override ci/prow/e2e-aws |
@njhale: Overrode contexts on behalf of njhale: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: dongwenjuan [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs