Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the description of validation "RegistryV1" format #480

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

dongwenjuan
Copy link
Contributor

@dongwenjuan dongwenjuan commented Oct 16, 2020

Signed-off-by: dongwenjuan [email protected]

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Sorry, something went wrong.

@openshift-ci-robot
Copy link

Hi @dongwenjuan. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2020
@ankitathomas
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 20, 2020
@dongwenjuan
Copy link
Contributor Author

dongwenjuan commented Oct 30, 2020

/assign @ankitathomas

@njhale
Copy link
Member

njhale commented Nov 16, 2020

@dongwenjuan we appreciate you taking the time to make this change, but for future reference, we typically hold off on including such small doc/style changes until we have a more substantive patch that we can include them in.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongwenjuan, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@dongwenjuan
Copy link
Contributor Author

@dongwenjuan we appreciate you taking the time to make this change, but for future reference, we typically hold off on including such small doc/style changes until we have a more substantive patch that we can include them in.

/lgtm
/approve

OK, thanks~

@njhale njhale added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 17, 2020
@njhale
Copy link
Member

njhale commented Nov 17, 2020

Docs only, bypassing infra issues for this one.

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link

@njhale: Overrode contexts on behalf of njhale: ci/prow/e2e-aws

In response to this:

Docs only, bypassing infra issues for this one.

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit bc3d300 into operator-framework:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants