Bug 1878213: Update index add func to handle optional default channel

[dinhxuanvu]

Description of the change:
The default channel annotation is no longer required as default
channel information is now optional. Users may provide default
channel if they intend to update default channel information in
the index/DB.

The default channel may still be infered if package.yaml is present.
If the default channel cannot be infered, then the default channel
will be omitted.

Bundle validation will no longer error out if default channel
annotation is missing.

If default channel is not provided in annotations, the existing
default channel will remain the same.

For the case of the first bundle being added and the default channel
isn't provided, it will be inferred from provided channel list if
there is only one channel. Otherwise, the index add will fail until
the default channel is provided.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

@dinhxuanvu: This pull request references Bugzilla bug 1878213, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1878213: Update index add func to handle optional default channel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dinhxuanvu]

@joelanford Slight change of plan. I planned to make 2 PRs for validation and for index add change but the PR is not that complex. So I keep everything in one. Plus, we need a BZ for every PR due to master is still closed which is a bit of unnecessary hassle.

[exdx]

/lgtm

[exdx]

nit: since this error is user facing I think it could be more descriptive. Users can run into this issue and its not very intuitive why.

fmt.Errorf("channel %s, labelled as default in annotations.yaml, not found in existing package channels", defaultChan)

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[dinhxuanvu]

/hold

[ecordell]

/lgtm

[dinhxuanvu]

/hold cancel

[exdx]

/lgtm

[dinhxuanvu]

/bugzilla refresh

[openshift-ci-robot]

@dinhxuanvu: This pull request references Bugzilla bug 1878213, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[dinhxuanvu]

/retest

[openshift-ci-robot]

@dinhxuanvu: All pull requests linked via external trackers have merged:

• operator-framework/operator-registry#451

Bugzilla bug 1878213 has been moved to the MODIFIED state.

In response to this:

Bug 1878213: Update index add func to handle optional default channel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dinhxuanvu]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@dinhxuanvu: #451 failed to apply on top of branch "release-4.5":

Applying: The default channel info/annotation is optional & not required
Using index info to reconstruct a base tree...
M	docs/design/operator-bundle.md
M	pkg/lib/bundle/generate.go
M	pkg/lib/bundle/generate_test.go
M	pkg/lib/bundle/validate.go
M	pkg/registry/types.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/registry/types.go
Auto-merging pkg/lib/bundle/validate.go
CONFLICT (content): Merge conflict in pkg/lib/bundle/validate.go
Auto-merging pkg/lib/bundle/generate_test.go
Auto-merging pkg/lib/bundle/generate.go
CONFLICT (content): Merge conflict in pkg/lib/bundle/generate.go
Auto-merging docs/design/operator-bundle.md
CONFLICT (content): Merge conflict in docs/design/operator-bundle.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 The default channel info/annotation is optional & not required
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.