-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add skips/replaces to listbundles api #381
feat(api): add skips/replaces to listbundles api #381
Conversation
the resolver needs this information grpc ecosystem changed since the last codegen, so this commit also includes all of the required tooling changes to generate via the latest tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-4.5 |
@benluddy: #381 failed to apply on top of branch "release-4.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
This adds skip and replace data to the listbundles endpoint.
Motivation for the change:
The (new, sat-solver-based) resolver needs this information so that it can decide what updates are valid for an existing installed operator.
Also, the grpc ecosystem changed since the last codegen, so this commit
includes all of the required tooling changes to generate via the latest tools
Reviewer Checklist
/docs