Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/lib/bundle/generate.go: add JSON tag to AnnotationMetadata #380

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 8, 2020

Description of the change: add a `json` tag to AnnotationMetadata

Motivation for the change: some YAML parsing libraries use JSON under the hood. This change allows both direct and indirect YAML parsers to understand AnnotationMetadata.

See operator-framework/operator-sdk#3120 (comment) for why this is a nice-to-have.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
estroz Eric Stroczynski
@estroz
Copy link
Member Author

estroz commented Jul 8, 2020

Didn't see that this struct is available in the api library. Closing. These are not the same struct, whoops. This PR is still necessary.

@estroz estroz closed this Jul 8, 2020
@estroz estroz reopened this Jul 8, 2020
@estroz
Copy link
Member Author

estroz commented Jul 8, 2020

/retest

@Bowenislandsong
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@estroz
Copy link
Member Author

estroz commented Jul 8, 2020

/test unit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants