fix(opm): refactor indexer #300
Merged
+47
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
njhale
approved these changes
Apr 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
needs-rebase
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
openshift-ci-robot
added
triage/unresolved
this refactors the indexer to make database extraction re-usable across indexer actions it also factors out a helper in the containerd registry to make future use of manifests simpler
ecordell
force-pushed
the
refactor-indexer
branch
from
c55e581 to
8a386fc
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
this refactors the indexer to make database extraction re-usable
across indexer actions
it also factors out a helper in the containerd registry to make future
use of manifests simpler
Motivation for the change:
This was originally done in response to comments on #283, but inadvertently didn't get pushed.
Reviewer Checklist
/docs