Bug 1826766: fix(types): Fix GetDependencies func that returns duplicate items #289
Conversation
openshift-ci-robot
added
the
approved
dinhxuanvu
changed the title
openshift-ci-robot
added
bugzilla/unspecified
bugzilla/valid-bug
|
@dinhxuanvu: This pull request references Bugzilla bug 1826766, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The iterator loop reuses item pointer which leads to duplicate of the same dependencies while other dependencies are missing out. Signed-off-by: Vu Dinh <[email protected]>
dinhxuanvu
force-pushed
the
fix-dep-types
branch
from
82d37bb to
cfb8d0f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@dinhxuanvu: This pull request references Bugzilla bug 1826766, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-low
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@dinhxuanvu: All pull requests linked via external trackers have merged: operator-framework/operator-registry#289. Bugzilla bug 1826766 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The iterator loop reuses item pointer which leads to duplicate of the
same dependencies while other dependencies are missing out.
Signed-off-by: Vu Dinh [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs