Skip to content

fix(add): allow containertool to be specified for registry add #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix(add): allow containertool to be specified for registry add #279

merged 1 commit into from
Apr 16, 2020
+447 −92

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Apr 16, 2020 •
edited
Loading

Description of the change:
Registry add by default will use containerd, but we continue to support
podman and docker.

Motivation for the change:
This is to continue supporting registries.conf for users relying on podman for registry add.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Sorry, something went wrong.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@ecordell ecordell force-pushed the demonless-index-cmds branch from 2c24b57 to 2453dc0 Compare April 16, 2020 19:35
@ecordell
fix(add): allow containertool to be specified for registry add

Verified

This commit was signed with the committer’s verified signature.
pietroalbini Pietro Albini
GPG key ID: CD76B35F7734769E
Verified
Learn about vigilant mode
a16399f 
registry add by default will use containderd, but we continue to support
podman and docker
@ecordell ecordell force-pushed the demonless-index-cmds branch from 2453dc0 to a16399f Compare April 16, 2020 20:01
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
gallettilance
gallettilance approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, gallettilance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member Author

Prow seems confused, the last run passed:

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/operator-framework_operator-registry/279/pull-ci-operator-framework-operator-registry-master-unit/807

@ecordell ecordell merged commit f170e90 into operator-framework:master Apr 16, 2020
@ecordell ecordell mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallettilance gallettilance

@awgreene awgreene

@njhale njhale

Assignees

@kevinrizza kevinrizza

@gallettilance gallettilance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ecordell @kevinrizza @openshift-ci-robot @gallettilance