Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dockerfile): user needs enough access to read from the filesystem #24

Merged
merged 1 commit into from
Jan 27, 2019
Merged

fix(dockerfile): user needs enough access to read from the filesystem #24

merged 1 commit into from
Jan 27, 2019
+10 −2

Conversation

ecordell
Copy link
Member

Adds appropriate files to the root group so that they're available in openshift

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2019
njhale
njhale approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@jpeeler
Copy link

jpeeler commented Jan 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ecordell,jpeeler,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

ecordell commented Jan 26, 2019 via email

@ecordell
Copy link
Member Author

/retest

4 similar comments
@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@njhale
Copy link
Member

njhale commented Jan 26, 2019

/retest

@ecordell
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit dca0cdd into operator-framework:master Jan 27, 2019
@ecordell ecordell deleted the root-downstream branch March 25, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale

@alecmerdler alecmerdler

@dinhxuanvu dinhxuanvu

Assignees

@jpeeler jpeeler

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ecordell @jpeeler @openshift-ci-robot @njhale @openshift-merge-robot