-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1815957: fix(dns): fix slow dns resolution of localhost for grpc health probe #227
Bug 1815957: fix(dns): fix slow dns resolution of localhost for grpc health probe #227
Conversation
Cool! Here's what I found:
|
This is tricky, since the source image can vary on user input and there's no guarantee we'll have |
@ecordell, then do you think opm should just attempt to generate the file at runtime? |
@njhale Updated with your suggestion. In the downstream image, nsswitch is already populated correctly. I tested with the upstream image as well: /go # cat /etc/nsswitch.conf
cat: can't open '/etc/nsswitch.conf': No such file or directory
/go # /registry-server &
/go # cat /etc/nsswitch.conf
hosts: files dns/go |
/retest |
1 similar comment
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, dinhxuanvu, ecordell, exdx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ecordell: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@ecordell: new pull request created: #269 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Adds an nsswitch.conf to prefer local files over dns for resolution.
Motivation for the change:
see: golang/go#35305
Reviewer Checklist
/docs