Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump Go v1.23.0 #1431

Merged

Conversation

perdasilva
Copy link
Contributor

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from exdx and rashmigottipati August 29, 2024 09:37
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 112 lines in your changes missing coverage. Please review.

Project coverage is 46.82%. Comparing base (377b709) to head (5e4e1c2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/api/registry_grpc.pb.go 0.00% 48 Missing ⚠️
...ertools/containertoolsfakes/fake_command_runner.go 0.00% 16 Missing ⚠️
pkg/sqlite/sqlitefakes/fake_rowscanner.go 0.00% 12 Missing ⚠️
...s/containertoolsfakes/fake_dockerfile_generator.go 0.00% 4 Missing ⚠️
...inertools/containertoolsfakes/fake_label_reader.go 0.00% 4 Missing ⚠️
pkg/lib/indexer/indexerfakes/fake_index_adder.go 0.00% 4 Missing ⚠️
pkg/lib/indexer/indexerfakes/fake_index_deleter.go 0.00% 4 Missing ⚠️
...kg/lib/indexer/indexerfakes/fake_index_exporter.go 0.00% 4 Missing ⚠️
.../lib/registry/registryfakes/fake_registry_adder.go 0.00% 4 Missing ⚠️
...ib/registry/registryfakes/fake_registry_deleter.go 0.00% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   46.80%   46.82%   +0.01%     
==========================================
  Files         135      135              
  Lines       15760    15754       -6     
==========================================
  Hits         7377     7377              
+ Misses       7342     7336       -6     
  Partials     1041     1041              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2024
@grokspawn
Copy link
Contributor

/hold cancel

@perdasilva can you rebase this one for queuing?

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2025
bentito and others added 3 commits January 10, 2025 13:03
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@camilamacedo86
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into operator-framework:master with commit 086a83b Jan 10, 2025
10 of 12 checks passed
perdasilva pushed a commit to perdasilva/operator-registry that referenced this pull request Jan 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
* Revert ":seedling: Bump Go v1.23.0 (#1431)"

This reverts commit 086a83b.

* Bump to go1.33

Signed-off-by: Per Goncalves da Silva <[email protected]>

* Update bingo deps

Signed-off-by: Per Goncalves da Silva <[email protected]>

* Regenerate generated code and fakes

Signed-off-by: Per Goncalves da Silva <[email protected]>

---------

Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Brett Tofel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants