Bundle validate lib functions #143
Merged
+57,817
−3,670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
kevinrizza
force-pushed
the
bundle-validate
branch
from
93a8dfa to
8525774
Compare
ecordell
reviewed
Dec 20, 2019
njhale
reviewed
Dec 20, 2019
kevinrizza
force-pushed
the
bundle-validate
branch
from
8525774 to
e62757c
Compare
|
@njhale @ecordell @joelanford updated based on latest feedback. Although I couldn't find that yamlorjson unmarshaler you were referring to Evan. Maybe you could point me to one? |
joelanford
reviewed
Dec 20, 2019
joelanford
reviewed
Dec 20, 2019
|
@kevinrizza https://github.com/operator-framework/operator-lifecycle-manager/blob/master/pkg/controller/registry/resolver/steps.go#L119-L127 (from |
joelanford
reviewed
Dec 20, 2019
joelanford
reviewed
Dec 20, 2019
joelanford
reviewed
Dec 20, 2019
joelanford
reviewed
Dec 20, 2019
joelanford
reviewed
Dec 20, 2019
joelanford
reviewed
Dec 20, 2019
kevinrizza
force-pushed
the
bundle-validate
branch
from
e62757c to
fdf9c13
Compare
openshift-ci-robot
added
the
needs-rebase
kevinrizza
force-pushed
the
bundle-validate
branch
from
fdf9c13 to
026f1e5
Compare
openshift-ci-robot
removed
the
needs-rebase
kevinrizza
force-pushed
the
bundle-validate
branch
from
026f1e5 to
d18e070
Compare
ecordell
reviewed
Jan 2, 2020
estroz
reviewed
Jan 2, 2020
estroz
reviewed
Jan 2, 2020
estroz
reviewed
Jan 2, 2020
estroz
reviewed
Jan 2, 2020
openshift-ci-robot
added
the
needs-rebase
1. Enable bundle image validation: manifests and annotations.yaml 2. Add internal opm cli to use validation feature Signed-off-by: Vu Dinh <[email protected]>
Updated the bundle validation lib functions to expose separate functions for pulling and validating bundles -- this allows the operator sdk to run this validation against locally created bundle directories Condensed some of the bundle image parsing code to use the common containertool functions already defined elsewhere in the project Additionally, updated the logging and validation error collection to be more configurable
1. Improve helm chart validation 2. Return right away if annotations file is not found Signed-off-by: Vu Dinh <[email protected]>
Signed-off-by: Vu Dinh <[email protected]>
dinhxuanvu
force-pushed
the
bundle-validate
branch
from
9df82d3 to
8e21f5e
Compare
openshift-ci-robot
removed
the
needs-rebase
|
@ecordell @joelanford @estroz Ready for final review |
| if workingDir == "" { | ||
| rootTarfile := filepath.Join(options.WorkingDir, "bundle.tar") | ||
|
|
||
| if options.WorkingDir == "" { | ||
| workingDir, err := ioutil.TempDir("./", "bundle_staging_") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer os.RemoveAll(workingDir) |
There was a problem hiding this comment.
should we be consistent and catch this removeall error too?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This pull request adds bundle validation lib functions to validate the format of the image itself
It also includes an example implementation of these validation functions in
opm alpha bundle validateMotivation for the change:
This change is intended to provide a common functional library for the operator-sdk and any other callers to validate that bundle images are in the prescribed format. Additionally, this pr provides a convenient function that understands how to shell out to container tooling and pull the contents of bundle images into a specified local directory (via
podman/docker saveandpull)Reviewer Checklist
/docs