test(server): wait for connection to go healthy before running tests #119
Conversation
this may reduce flakiness for the server e2e tests
openshift-ci-robot
added
approved
|
/lgtm |
|
/refresh |
|
/lgtm |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
| @@ -75,6 +77,10 @@ func client(t *testing.T) (api.RegistryClient, *grpc.ClientConn) { | |||
| if err != nil { | |||
| t.Fatalf("did not connect: %v", err) | |||
| } | |||
|
|
|||
| ctx, _ := context.WithTimeout(context.Background(), 30*time.Second) | |||
| conn.WaitForStateChange(ctx, connectivity.TransientFailure) | |||
There was a problem hiding this comment.
This is weird to me. Shouldn't this be connectivity.Ready?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
openshift-ci-robot
added
triage/unresolved
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
Waits for the grpc connection to go healthy before running tests.
Motivation for the change:
This may reduce flakiness for the server e2e tests
Reviewer Checklist
/docs