-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data storage for registry API #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out the code locally, looks good. LGTM
I see that the CRDs are not packaged into the sqlite store. What is the plan for that? Otherwise I tried it out locally and it LGTM. |
@aravindhp the CRDs are all stored in the |
Sounds good, @ecordell. The |
Remove obsolete fields
Signed-off-by: Rashmi Gottipati <[email protected]>
… to a file-based catalog (#1127) * Documentation on how to add a plain bundle to a file-based catalog Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback Signed-off-by: Rashmi Gottipati <[email protected]> * Clarify regular bundle to be of registry+v1 format Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback #1 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback #2 Signed-off-by: Rashmi Gottipati <[email protected]> * Address review feedback #3 Signed-off-by: Rashmi Gottipati <[email protected]> * Add an example for the desired channel name and link to OLM best practices for channel naming conventions Signed-off-by: Rashmi Gottipati <[email protected]> --------- Signed-off-by: Rashmi Gottipati <[email protected]>
DirectoryLoader
that takes a directory of manifests and loads them into a databaseLoad
interface and an implementation for SQLlite to add data into the sqlite store (called by theDirectoryLoader
Query
interface that implements the queries we will need for the http APIThe next step is defining the http interface, and then talking to it from OLM.