Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data storage for registry API #1

Merged
merged 5 commits into from
Oct 10, 2018

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Oct 9, 2018

  • Adds a DirectoryLoader that takes a directory of manifests and loads them into a database
  • Adds a Load interface and an implementation for SQLlite to add data into the sqlite store (called by the DirectoryLoader
  • Adds a Query interface that implements the queries we will need for the http API
  • Adds a dockerfile that loads a set of manifests into a sqlite.db

The next step is defining the http interface, and then talking to it from OLM.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ecordell ecordell requested review from njhale, alecmerdler, jpeeler and aravindhp and removed request for njhale October 9, 2018 20:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the code locally, looks good. LGTM

@ecordell ecordell merged commit 3ebf38c into operator-framework:master Oct 10, 2018
@aravindhp
Copy link
Member

I see that the CRDs are not packaged into the sqlite store. What is the plan for that? Otherwise I tried it out locally and it LGTM.

@ecordell
Copy link
Member Author

@aravindhp the CRDs are all stored in the operatorbundle.bundle field in the DB. Basically the bundle is "everything you need", the CSV + the CRDs + potentially extra objects like an SCC, etc.

@aravindhp
Copy link
Member

aravindhp commented Oct 10, 2018

Sounds good, @ecordell. The time="2018-10-10T13:50:28Z" level=info msg="skipping non-csv file" dir=manifests file=etcdcluster.crd.yaml load=bundles messages shown when the container is being built misled me.

philbrookes added a commit to philbrookes/operator-registry that referenced this pull request Apr 24, 2019
everettraven pushed a commit to everettraven/operator-registry that referenced this pull request Apr 18, 2023
rashmigottipati added a commit to rashmigottipati/operator-registry that referenced this pull request Jul 24, 2023
openshift-merge-robot pushed a commit that referenced this pull request Jul 25, 2023
… to a file-based catalog (#1127)

* Documentation on how to add a plain bundle to a file-based catalog

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback

Signed-off-by: Rashmi Gottipati <[email protected]>

* Clarify regular bundle to be of registry+v1 format

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback #1

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback #2

Signed-off-by: Rashmi Gottipati <[email protected]>

* Address review feedback #3

Signed-off-by: Rashmi Gottipati <[email protected]>

* Add an example for the desired channel name and link to OLM best practices for channel naming conventions

Signed-off-by: Rashmi Gottipati <[email protected]>

---------

Signed-off-by: Rashmi Gottipati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants