Skip to content

✨ Upgrade bingo deps #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

✨ Upgrade bingo deps #3601

merged 1 commit into from
Jun 24, 2025

Conversation

camilamacedo86
Copy link
Contributor

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from anik120 and joelanford June 23, 2025 19:38
@tmshort
Copy link
Contributor

tmshort commented Jun 24, 2025

Some of the .bingo *.mod files were not completely updated to 1.24.x... you might want to double-check this.

@tmshort
Copy link
Contributor

tmshort commented Jun 24, 2025

OK, I ran the bingo updater locally, and this seems fine. Although there's an update to the go.mod file that is separate.

@tmshort
Copy link
Contributor

tmshort commented Jun 24, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 24, 2025
@tmshort tmshort added the override-go-verdiff Overrides the go-verdiff test label Jun 24, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3c2163e into operator-framework:master Jun 24, 2025
14 of 15 checks passed
@camilamacedo86 camilamacedo86 deleted the bingo-upgrade branch June 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort approved these changes

@perdasilva perdasilva Awaiting requested review from perdasilva

@anik120 anik120 Awaiting requested review from anik120

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. override-go-verdiff Overrides the go-verdiff test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilamacedo86 @tmshort