Add Channel to Operator API #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just add the Channel to the API Fixes operator-framework#169 Fixes OPRUN-2916 Signed-off-by: Todd Short <[email protected]>
joelanford
reviewed
Apr 17, 2023
| @@ -37,6 +37,11 @@ type OperatorSpec struct { | |||
| // | |||
| // For more information on semver, please see https://semver.org/ | |||
| Version string `json:"version,omitempty"` | |||
|
|
|||
| //+kubebuilder:validation:MaxLength:=48 | |||
| //+kubebuilder:validation:Pattern:=^[a-z0-9]+(-[a-z0-9]+)*$ | |||
There was a problem hiding this comment.
+1 on a super-well-defined pattern for channel name. Not important for this particular PR, but we should probably make sure opm agrees with this pattern (e.g. as part of opm validate)
joelanford
approved these changes
Apr 17, 2023
joelanford
reviewed
Apr 17, 2023
|
|
||
| //+kubebuilder:validation:MaxLength:=48 | ||
| //+kubebuilder:validation:Pattern:=^[a-z0-9]+(-[a-z0-9]+)*$ | ||
| // Channel constraint defintion |
There was a problem hiding this comment.
Nit: it might be nice to beef this up a little bit with a narrative about how the channel constraint works.
There was a problem hiding this comment.
I can do that once I actually implement it in the next PR
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add the Channel to the API
Fixes #169
Fixes OPRUN-2916