ZTS: Improve zts-auto_offline_001_pos #9827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
Component: Test Suite
Codecov Report
@@ Coverage Diff @@
## master #9827 +/- ##
========================================
- Coverage 80% 79% -<1%
========================================
Files 385 385
Lines 121492 121492
========================================
- Hits 96638 96541 -97
- Misses 24854 24951 +97
Continue to review full report at Codecov.
|
The zts-auto_offline_001_pos test could exceed the 10 minute test limit and be KILLED by the test infrastructure. To prevent this speed up the test case by: * Removing redundant pool configuations. Each of the following vdev types is tested once: mirror, raidz, cache, and special. * The block_device_wait function need only wait on the block device which has been removed as part of the test. Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf
force-pushed
the
zts-auto_offline_001_pos
branch
from
daa9385 to
35b1726
Compare
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 16, 2020
The zts-auto_offline_001_pos test could exceed the 10 minute test limit and be KILLED by the test infrastructure. To prevent this speed up the test case by: * Removing redundant pool configurations. Each of the following vdev types is tested once: mirror, raidz, cache, and special. * The block_device_wait function need only wait on the block device which has been removed as part of the test. Reviewed-by: Paul Zuchowski <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#9827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolve frequent Ubuntu 16.04 CI failures:
http://build.zfsonlinux.org/builders/Ubuntu%2016.04%20x86_64%20%28TEST%29/builds/10291
http://build.zfsonlinux.org/builders/Ubuntu%2016.04%20x86_64%20%28TEST%29/builds/10281
These coincide with updating CI infrastructure which is why the
failures were previously not observed.
Description
The zts-auto_offline_001_pos test could exceed the 10 minute test
limit and be KILLED by the test infrastructure. To prevent this
speed up the test case by:
Removing redundant pool configuations. Each of the following
vdev types is tested once: mirror, raidz, cache, and special.
The block_device_wait function need only wait on the block
device which has been removed as part of the test.
How Has This Been Tested?
Locally ran the modified ZTS test case. Pending confirmation
from the CI that this change sped up the test enough to prevent
it from being regularly killed.
The following are set to in order to get a quick CI test run.TEST_ZTEST_SKIP="yes"TEST_ZFSTESTS_TAGS="fault"[edit] Removed after a successful run. Resubmitted for a full ZTS run.
Types of changes
Checklist:
Signed-off-by.