Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl_vfs: fix vrele task runner signature mismatch #17101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aokblast
Copy link
Contributor

Motivation and Context

Signature mismatch for vrele dispatcher

Description

How Has This Been Tested?

Build on FreeBSD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@aokblast aokblast force-pushed the fix_vrele branch 4 times, most recently from 89b4178 to 884270c Compare February 28, 2025 15:42
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, but I wonder why does it matter? Some sort of code analyzer? And also is this the only such case in the code?

PS: Please rebase on top of the new master to fix Fedora builds.

@aokblast
Copy link
Contributor Author

aokblast commented Mar 3, 2025

Hello. Thanks for your review. I am importing Kernel CFI to FreeBSD. Here is the patch. https://reviews.freebsd.org/D46193.
I have sent 10 patches to FreeBSD base on fixing signature mismatch. I apologize on the annoying behavior. But I have no other way to fix all mismatch at one time excepts for digging into all zfs code. So I stareted a vm and let them running some tasks for 1 days. Fortunately, there is no KCFI trap triggered anymore. It means this maybe the latest patch on zfs about signature mismatch.

@amotin
Copy link
Member

amotin commented Mar 3, 2025

@aokblast Thanks. But when you are ready, please rebase as I have said, since I have no permissions to merge PRs that haven't passed required CI tests and somebody else would have to do it.

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Mar 3, 2025
@aokblast
Copy link
Contributor Author

aokblast commented Mar 4, 2025

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants