Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vdev state for spare vdev #14653

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Update vdev state for spare vdev #14653

merged 1 commit into from
Mar 24, 2023

Conversation

ixhamza
Copy link
Member

@ixhamza ixhamza commented Mar 20, 2023

zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but it does not get updated nvlist configuration for spare vdev since the configuration is read by spa_spares->sav_config. In this commit, updating the vdev state for spare vdev that is consumed by zfsd on spare disk hotplug.
FreeBSD zfsd PR: freebsd/freebsd-src#697

How Has This Been Tested?

Tested on FreeBSD by spare disk hotplug and sanity test on linux

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ixhamza
Copy link
Member Author

ixhamza commented Mar 20, 2023

cc: @amotin

amotin
amotin approved these changes Mar 21, 2023
View reviewed changes
@ixhamza
Update vdev state for spare vdev
c88ff1b 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Signed-off-by: Ameer Hamza <[email protected]>
@ixhamza ixhamza mentioned this pull request Mar 21, 2023
Closed
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 22, 2023
@behlendorf behlendorf merged commit a05263b into openzfs:master Mar 24, 2023
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Mar 26, 2023
@ixhamza @andrewc12
Update vdev state for spare vdev
cb9e91b 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14653
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Mar 26, 2023
@ixhamza @andrewc12
Update vdev state for spare vdev
86eb0ad 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14653
ixhamza added a commit to truenas/zfs that referenced this pull request Mar 26, 2023
@ixhamza
Update vdev state for spare vdev
3e72469 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14653
@ixhamza ixhamza mentioned this pull request Mar 26, 2023
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Mar 27, 2023
@ixhamza @behlendorf
Update vdev state for spare vdev
aa7258c 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes #14653
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 5, 2023
@ixhamza @tonyhutter
Update vdev state for spare vdev
97de9cb 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14653
@ixhamza ixhamza deleted the NAS-115112 branch August 2, 2023 17:16
pcd1193182 pushed a commit to pcd1193182/zfs that referenced this pull request Sep 26, 2023
@ixhamza @manoj-joseph
Update vdev state for spare vdev
a19eeef 
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but
it does not get updated nvlist configuration for spare vdev since
the configuration is read by spa_spares->sav_config. In this commit,
updating the vdev state for spare vdev that is consumed by zfsd on
spare disk hotplug.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ixhamza @behlendorf @amotin