Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove atomics from zh_refcount. #14196

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Remove atomics from zh_refcount. #14196

merged 1 commit into from
Nov 28, 2022

Conversation

amotin
Copy link
Member

@amotin amotin commented Nov 18, 2022

It is protected by z_hold_locks, so we do not need more serialization, simple integer math should be fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Remove atomics from zh_refcount.
1c146d2 
It is protected by z_hold_locks, so we do not need more serialization,
simple integer math should be fine.

Signed-off-by:  Alexander Motin <[email protected]>
@amotin amotin requested a review from behlendorf November 18, 2022 19:00
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 18, 2022
ryao
ryao approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@ryao ryao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@behlendorf behlendorf merged commit 5f45e3f into openzfs:master Nov 28, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 28, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 16, 2022
@amotin @andrewc12
Remove atomics from zh_refcount
f8deed3 
It is protected by z_hold_locks, so we do not need more serialization,
simple integer math should be fine.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Closes openzfs#14196
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 17, 2022
@amotin @andrewc12
Remove atomics from zh_refcount
3c8a86c 
It is protected by z_hold_locks, so we do not need more serialization,
simple integer math should be fine.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Closes openzfs#14196
amotin added a commit to amotin/zfs that referenced this pull request Mar 2, 2023
@amotin
Remove atomics from zh_refcount
55a0ad2 
It is protected by z_hold_locks, so we do not need more serialization,
simple integer math should be fine.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Closes openzfs#14196
behlendorf pushed a commit that referenced this pull request Mar 2, 2023
@amotin @behlendorf
Remove atomics from zh_refcount
2098a00 
It is protected by z_hold_locks, so we do not need more serialization,
simple integer math should be fine.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by:  Alexander Motin <[email protected]>
Closes #14196
@amotin amotin deleted the zh_refcount branch October 9, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryao ryao ryao approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @behlendorf @ryao