Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c #13885

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c #13885

merged 1 commit into from
Sep 15, 2022

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Sep 13, 2022 •
edited
Loading

Motivation and Context

We pass sizeof (struct redact_record *) rather than sizeof (struct redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Description

We fix it to pass the record size.

How Has This Been Tested?

The buildbot is expected to test for us.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

behlendorf
behlendorf approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, the consequence of this appears to be we could enqueue more than the max size specified in bqueue_init().

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 13, 2022
@ryao
Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c
e6caf9f 
We pass sizeof (struct redact_record *) rather than sizeof (struct
redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Signed-off-by: Richard Yao <[email protected]>
@behlendorf behlendorf merged commit ddb1fd9 into openzfs:master Sep 15, 2022
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 22, 2022
@ryao @tonyhutter
Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c
5096ed3 
We pass sizeof (struct redact_record *) rather than sizeof (struct
redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13885
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 27, 2022
@ryao @andrewc12
Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c
f6baa50 
We pass sizeof (struct redact_record *) rather than sizeof (struct
redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13885
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@ryao @andrewc12
Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c
bf1cd63 
We pass sizeof (struct redact_record *) rather than sizeof (struct
redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13885
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@ryao @andrewc12
Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c
ad98f0b 
We pass sizeof (struct redact_record *) rather than sizeof (struct
redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13885
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@ryao @andrewc12
Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c
6c9d3b7 
We pass sizeof (struct redact_record *) rather than sizeof (struct
redact_record). Passing the pointer size is wrong.

Coverity caught this in two places.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryao @behlendorf